Add priorityClassName support #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszsek
requested changes
Apr 7, 2020
anxolerd
added a commit
to anxolerd/kubernetes-operator
that referenced
this pull request
Apr 7, 2020
As per jenkinsci#322 (comment) jenkins-operator should have enough permissions to get priorityclasses now. Modify the role in the corresponding way.
|
It will be great if we could check this in e2e https://github.com/jenkinsci/kubernetes-operator/blob/master/test/e2e/jenkins.go#L69. |
|
@tomaszsek , I reverted validation, as it compicates things in multitenant environment and added e2e test. I have a question regarding e2e tests: is it possible to check negative cases (i.e. when reconcile loop fails) in those? If possible, how can I achieve that and how can I check error messages in tests then? |
|
Tests are failing due to this: kubernetes/kubernetes#60596 |
|
You can bump minikube Kubernetes version here https://github.com/jenkinsci/kubernetes-operator/blob/master/config.minikube.env#L3 |
anxolerd
force-pushed
the
321-add-priority-class-name
branch
from
ec4e99c to
3572f7e
Compare
Allow to set priorityClassName for master pod. This will make possible for jenkins master to either not be preempted on other's pod low resources or to preempt lesser priority pods on resources shortage. Ref: jenkinsci#321
As it is quite difficult to set cluster-wide objects in test and don't break other tests, which are running in parallel, rely on pre-created priorityClass (which is already in the cluster by default) in test.
anxolerd
force-pushed
the
321-add-priority-class-name
branch
3 times, most recently
from
628a17a to
9b468f8
Compare
anxolerd
force-pushed
the
321-add-priority-class-name
branch
from
9b468f8 to
7c5f41f
Compare
|
@tomaszsek , after tons of struggling with e2e, i finally managed to make tests pass! |
tomaszsek
approved these changes
Apr 11, 2020
|
@anxolerd Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to set priorityClassName for master pod. This will make possible
for jenkins master to either not be preempted on other's pod low
resources or to preempt lesser priority pods on resources shortage.
API changes
Add
spec.master.priorityClassNamefield toJenkinsCR, which corresponds tospec.priorityClassNamefield inPodspec. Field type isstring, it should be either name of a validscheduling.k8s.io/v1/PriorityClassor empty string.Linked issues
Closes #321