Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple changes for you to consider #7

Closed
wants to merge 10 commits into from
Closed

Multiple changes for you to consider #7

wants to merge 10 commits into from

Conversation

MarkEWaite
Copy link

Multiple changes to consider

You're welcome to ignore any and all of these changes. I offer them for your consideration:

  • Updating cd.yml file (from the master branch, not yet on the main branch)
  • adding yaml file (from the master branch, not yet on the main branch)
  • Do not ignore .mvn dir contents (already in another pull request)
  • Use parent pom 4.24 (would be best if dependabot were enabled on this repo)
  • Use changelist property for version (incrementals) (already in another pull request)
  • Use scmTag symbol, not explicit tag (already in another pull request)
  • Use most recent plugin bom release (would be best if dependabot were enabled on this repo)
  • Use most recent JQuery plugin release (see the comment that explains why you should use a different JQuery library)
  • Remove unused dependency, do not include jsr305 jar in hpi (remove jsr305 jar from the hpi because it is not needed)

BirSikanderMahajan and others added 10 commits August 13, 2021 19:45
@BirSikanderMahajan
Updating cd.yml file
f4c69c7
@BirSikanderMahajan
adding yaml file
f7e6b22
@MarkEWaite
Do not ignore .mvn dir contents
e8b3d52
@MarkEWaite
Use parent pom 4.24
d13bd92
@MarkEWaite
Use changelist property for version (incrementals)
09fa8dc
@MarkEWaite
Use scmTag symbol, not explicit tag
1f89032
@MarkEWaite
Use most recent plugin bom release
518a0d5 
Provides the most current set of dependency versions.
@MarkEWaite
Use most recent JQuery plugin release
99fc9be 
The JQuery plugin is deprecated and JQuedry 1.12 is no longer receiving
updates.  If you truly need JQuery, you may want to consider using the
https://plugins.jenkins.io/jquery3-api/ JQuery 3 API plugin.  It has an
active maintainer and regularly receives updates.
@MarkEWaite
Remove unused dependency, do not include jsr305 jar in hpi
83c9b7c 
The spotbugs-annotations package is actively maintained and has recent
releases.  Use it instead of outdated com.google.code.findbugs that has
not been released in 4 years.

Removes other dependencies that are not required for compilation or
tests so that unnecessary classes are not loaded into Jenkins.
@AntonLiakhovich
Merge branch 'main' into add-incrementals
bb83408
@MarkEWaite
Copy link
Author

Closing because #23 is a better choice for the continuous delivery changes and because it appears that pull requests are being evaluated in https://github.com/leapwork/Jenkins-plugin and are being ignored in this repository. That's not typical for Jenkins plugins to be forked into the jenkinsci GitHub organization and then have pull requests ignored in the fork.

@MarkEWaite MarkEWaite closed this Jul 23, 2022
@MarkEWaite MarkEWaite deleted the add-incrementals branch July 29, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkEWaite @BirSikanderMahajan @AntonLiakhovich