Modernize to Jenkins 2.440.3 #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D Co-authored-by: Moderne <[email protected]>
|
See #303 |
jglick
reviewed
Aug 5, 2024
| @@ -23,7 +23,7 @@ | |||
| </licenses> | |||
| <properties> | |||
| <changelist>999999-SNAPSHOT</changelist> | |||
| <jenkins.version>2.440.1</jenkins.version> | |||
| <jenkins.version>2.440.3</jenkins.version> | |||
There was a problem hiding this comment.
Why was this closed @alecharp? This change is also needed to match https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
|
Because I included it in the BOM update.
Le lun. 5 août 2024, 18:59, Jesse Glick ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In pom.xml
<#301 (comment)>
:
> @@ -23,7 +23,7 @@
</licenses>
<properties>
<changelist>999999-SNAPSHOT</changelist>
- <jenkins.version>2.440.1</jenkins.version>
+ <jenkins.version>2.440.3</jenkins.version>
Why was this closed @alecharp <https://github.com/alecharp>? This change
is also needed to match
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
—
Reply to this email directly, view it on GitHub
<#301 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHQWY4OJAIMSN65GECJJW3ZP6VORAVCNFSM6AAAAABL7NPV5GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJZGQ3TQMZWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah, #302 (was not linked). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR aims to move this plugin to the recommended Jenkins baseline version.
If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.
Testing done
Ran
mvn clean verify.Submitter checklist
Refs: sghill-rewrite/campaigns#4
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D