Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci.pipeline.run.duration metric #959

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Add ci.pipeline.run.duration metric #959

merged 15 commits into from
Nov 5, 2024

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Oct 1, 2024 •
edited
Loading

  • Add ci.pipeline.run.duration{ci.pipeline.id=xxx, ci.pipeline.run.result=yyy} histogram metric
    • Config params otel.instrumentation.jenkins.run.metric.duration.allow_list and otel.instrumentation.jenkins.run.metric.duration.allow_list: Java regex strings
  • Cleanup some docs

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cyrille-leclerc cyrille-leclerc mentioned this pull request Oct 1, 2024
Open
@cyrille-leclerc cyrille-leclerc mentioned this pull request Oct 25, 2024
Closed
@cyrille-leclerc cyrille-leclerc marked this pull request as ready for review October 25, 2024 16:54
@cyrille-leclerc
Copy link
Contributor Author

@miraccan00 could you review this PR please?

cyrille-leclerc
cyrille-leclerc commented Oct 27, 2024
View reviewed changes
docs/monitoring-metrics.md Show resolved Hide resolved
docs/monitoring-metrics.md Show resolved Hide resolved
docs/monitoring-metrics.md Outdated Show resolved Hide resolved
@cyrille-leclerc cyrille-leclerc mentioned this pull request Oct 28, 2024
Closed
cyrille-leclerc
cyrille-leclerc commented Oct 29, 2024
View reviewed changes
Copy link
Contributor Author

@cyrille-leclerc cyrille-leclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuisathaverat can you please review this PR?

src/main/java/io/jenkins/plugins/opentelemetry/semconv/JenkinsSemanticMetrics.java Show resolved Hide resolved
@kuisathaverat kuisathaverat added the enhancement New feature or request label Nov 5, 2024
@cyrille-leclerc cyrille-leclerc merged commit 0d1a2fc into main Nov 5, 2024
17 checks passed
@cyrille-leclerc cyrille-leclerc deleted the add-ci.pipeline.run.duration-metric branch November 5, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophe-kamphaus-jemmic christophe-kamphaus-jemmic christophe-kamphaus-jemmic approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyrille-leclerc @kuisathaverat @christophe-kamphaus-jemmic