-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and tests to fix PCT failures #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abayer
approved these changes
Jan 19, 2019
Getting some build failures, perhaps some class went missing in one of my dependency updates. I'll need to look into this a little more:
|
Looks like the class in question was added in core 2.60, but we were still building against 2.32.x in the Jenkinsfile. Should be fixed by ddabb77. |
abayer
approved these changes
Mar 8, 2019
kshultzCB
approved these changes
Mar 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to jenkinsci/workflow-durable-task-step-plugin#95, jenkinsci/workflow-basic-steps-plugin#79, and jenkinsci/pipeline-input-step-plugin#31.
The most notable changes are updating the baseline to 2.121.1 as required by workflow-support 3.0, fixing some subtle change or race condition causing
BuildTriggerStepRestartTest#restartBetweenJobs
to fail consistently after upgrading dependencies, and updating the local data used forBuildTriggerStepTest#storedForm
to work with workflow-support 3.0.