Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test propagation of additional downstream result types #33

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

basil
Copy link
Member

@basil basil commented Sep 17, 2019

#24 changed the behavior of this plugin to propagate the result of downstream builds. However, only propagation of unstable builds was covered in unit tests, and the documentation was not updated. This PR adds test coverage for the other types of downstream statuses and updates the documentation.

@basil
Copy link
Member Author

basil commented Sep 18, 2019

FYI, I think #24 is going in the right direction, but it also makes me a bit nervous, because I'm not sure all of the parallel steps in my pipelines are going to correctly deal with the downgrade of build results as a result of this change in behavior. I may find some regressions in my jobs and have to introduce propagate: false and propagate the results from parallel steps manually instead. I expressed my use case in more detail in JENKINS-49073 (comment). As I described in that comment, I think allowing the parallel step to propagate the "worst" result from a set of parallel branches would be very helpful.

@basil
Copy link
Member Author

basil commented Oct 11, 2019

@dwnusbaum Gentle ping. No rush on this, but just wanted to make sure the first notification didn't slip by.

@dwnusbaum
Copy link
Member

@basil Sorry, it didn't slip by, I've just been swamped lately with other work. Not sure when I'll be able to take a look through open PRs.

@dwnusbaum dwnusbaum self-requested a review October 11, 2019 20:14
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dwnusbaum dwnusbaum merged commit b4a4e2f into jenkinsci:master Nov 25, 2019
@basil basil deleted the propagate branch November 23, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants