-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use '.jenkins-card' for cards #497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good only issue I found was overflow.
border-radius: 15px; | ||
padding: 20px; | ||
background: var(--card-background); | ||
overflow: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely this change causes graph overflow:
pipeline {
agent any
stages {
stage('Non-Parallel Stage') {
steps {
echo 'This stage will be executed first.'
}
}
stage('Parallel Stage') {
failFast true
parallel {
stage('Branch A') {
steps {
echo "On Branch A"
}
}
stage('Branch B') {
steps {
echo "On Branch B"
}
}
stage('Branch C') {
stages {
stage('Nested 1') {
steps {
echo "In stage Nested 1 within Branch C"
}
}
stage('Nested 2') {
steps {
echo "In stage Nested 2 within Branch C"
}
}
}
}
}
}
stage('Skipped stage') {
when {
branch 'master'
}
steps {
echo 'This stage will be skipped.'
}
}
stage('Parallel Stage 2') {
failFast true
parallel {
stage('Branch A') {
steps {
echo "On Branch A"
}
}
stage('Branch B') {
steps {
echo "On Branch B"
}
}
stage('Branch C') {
stages {
stage('Nested 1B') {
steps {
echo "In stage Nested 1B within Branch C"
}
}
stage('Nested 2B') {
steps {
echo "In stage Nested 2B within Branch C"
}
}
}
}
}
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely this change causes graph overflow:
``` pipeline { agent any stages { stage('Non-Parallel Stage') { steps { echo 'This stage will be executed first.' } } stage('Parallel Stage') { failFast true parallel { stage('Branch A') { steps { echo "On Branch A" } } stage('Branch B') { steps { echo "On Branch B" } } stage('Branch C') { stages { stage('Nested 1') { steps { echo "In stage Nested 1 within Branch C" } } stage('Nested 2') { steps { echo "In stage Nested 2 within Branch C" } } } } } } stage('Skipped stage') { when { branch 'master' } steps { echo 'This stage will be skipped.' } } stage('Parallel Stage 2') { failFast true parallel { stage('Branch A') { steps { echo "On Branch A" } } stage('Branch B') { steps { echo "On Branch B" } } stage('Branch C') { stages { stage('Nested 1B') { steps { echo "In stage Nested 1B within Branch C" } } stage('Nested 2B') { steps { echo "In stage Nested 2B within Branch C" } } } } } } } } ```
Good spot, should be sorted now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there's a couple of pending changes I'll see if we can get in before we bump the baseline, otherwise we can merge this in a week or two if those don't get sorted
Awesome, thanks! |
See #496
Introduced in jenkinsci/jenkins#9148 is the card component. This PR updates the graph view plugin to use those new styles, bringing it inline with core and removing a bunch of CSS. Also updated a few variables to Jenkins colours when possible.
Before
After
Testing done
Submitter checklist