Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-64015 Fix Job urls are set to the same color as the background in the Pipeline logs #122

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

marcjay
Copy link
Contributor

@marcjay marcjay commented Oct 30, 2020

Scope contrast fix that was added for JENKINS-63556 / #104 down to just the stage log link, allowing URLs in the logs to render as normal

Before: image
After: image

…d in the Pipeline logs

Scope contrast fix that was added for JENKINS-63556 / jenkinsci#104 down to just the stage log link, allowing URLs in the logs to render as normal
@olamy olamy added the bug label Oct 31, 2020
@olamy olamy merged commit f8ebdc0 into jenkinsci:master Nov 22, 2020
@marcjay
Copy link
Contributor Author

marcjay commented Dec 16, 2020

Hi @olamy - I don't mind that much if you take my commit and merge it to master as yourself, but a quick 'thank you' would go a long way, given the time put into troubleshooting the issue, coding a fix and then testing it. Thank you for merging my fix all the same.

@marcjay marcjay deleted the fix-64015-job-urls-background-color branch December 16, 2020 01:24
@olamy
Copy link
Member

olamy commented Dec 16, 2020

@marcjay take it easy mate..... it's the open source world.... You made the change and make it available as a pull request for the good of the community and that's perfect!
Not sure how long you are in the open source world but if you want to keep participating on it just do it in the spirit of helping others. People may be too busy to say thanks or bend the knee :) but they appreciate your contribution.. They even review it, test and accept it.

@marcjay
Copy link
Contributor Author

marcjay commented Dec 16, 2020

@marcjay take it easy mate.....

It was a polite comment, not heated in any way.

it's the open source world....
Not sure how long you are in the open source world but if you want to keep participating on it just do it in the spirit of helping others.

I've been doing this for quite a while, and contributed to many different projects - your approach is very much in the minority of maintainers.

People may be too busy to say thanks or bend the knee :) but they appreciate your contribution.. They even review it, test and accept it.

I don't know why you're talking about 'bending the knee', but I would never accept "too busy to say thank you" as an argument for anything, and especially not a community-driven OSS project, but I get that people are raised differently. Anyway, as I said, thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants