Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-69301 Update handlebars and replace js-libs with parcel #240

Merged
merged 17 commits into from
Aug 24, 2022

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Aug 19, 2022

https://issues.jenkins.io/browse/JENKINS-69301
Upgrade handlebars to 4.7.7 as a self-contained JS
Remove jenkins-js-libs and jenkins-js-builder dependencies
Move from jenkins-js-modules to @jenkins-cd/js-modules
Use parcel 2 as packager instead of gulp
Still use adjunct and js-modules for JS extension points

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jgreffe
Copy link
Contributor Author

jgreffe commented Aug 19, 2022

Not sure why there's this error during build:

[2022-08-19T13:53:12.412Z] [INFO] > parcel build --public-url ./ ./src/main/js/stageview.js --dist-dir ./src/main/webapp/jsmodules && parcel build --public-url ./ ./src/main/js/stageview_adjunct.js --dist-dir ./target/generated-adjuncts/org/jenkinsci/pipeline
[2022-08-19T13:53:12.412Z] [INFO] 
[2022-08-19T13:53:12.412Z] [INFO] Error: The specified module could not be found.
[2022-08-19T13:53:12.412Z] [INFO] \\?\C:\Jenkins\workspace\ipeline-stage-view-plugin_PR-240\ui\node_modules\@parcel\source-map\parcel_sourcemap_node\artifacts\index.win32-x64-msvc.node

Edit: fixed by using buildPlugin(useContainerAgent: false, configurations: [.

@@ -1,4 +1,4 @@
buildPlugin(useContainerAgent: true, configurations: [
buildPlugin(useContainerAgent: false, configurations: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary configuration in respect to jenkins-infra/helpdesk#3105

<frontend-version>1.10.0</frontend-version>
<node.version>18.7.0</node.version>
<npm.version>8.15.0</npm.version>
<frontend-version>1.12.1</frontend-version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade in order to make it pass with Mac M1 chips: eirslett/frontend-maven-plugin#952

@basil
Copy link
Member

basil commented Oct 5, 2022

Does this still need to be released?

This was referenced Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants