Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jdk21 build #316

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Add Jdk21 build #316

merged 9 commits into from
Oct 5, 2023

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Oct 2, 2023

Test with Java 21

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21

@gounthar gounthar marked this pull request as draft October 2, 2023 13:21
@gounthar gounthar marked this pull request as ready for review October 2, 2023 16:46
@olamy
Copy link
Member

olamy commented Oct 3, 2023

build looks to be stucked to get windows jdk11 node

@gounthar
Copy link
Contributor Author

gounthar commented Oct 3, 2023

Yes, it's been stuck for the last 17 hours.

@gounthar
Copy link
Contributor Author

gounthar commented Oct 3, 2023

Windows 2019 VM allocations are flaky.
Waiting for the issue to be solved.

configurations: [
[platform: "linux", jdk: "11"],
[platform: 'linux', jdk: 21],
[platform: 'windows', jdk: 17],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no need of 17.
Per my understanding Jenkins will jump directly from 11 to 21.
So 17 seems to be a no need for testing?
I would rather prefer having windows 11 and/or 21.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting soon, the weekly Jenkins releases will include an administrative monitor to notify users that Jenkins will no longer support Java 11 after September 30, 2024.

The official documentation is currently being updated to support JDK17. Additionally, starting this week, the default Docker images will use JDK17. JDK17 is now the preferred version for Jenkins until we eventually transition to JDK21.

For testing purposes, it's important to check the compatibility of your plugin with both JDK17 and JDK21. Regarding JDK11, the choice to continue using it is up to you. 🤗

@olamy olamy changed the title Jdk21 Add Jdk21 build Oct 5, 2023
@olamy olamy merged commit 5779a96 into jenkinsci:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants