Insert a versioned dep on a plugin otherwise mentioned only in tests classifier #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
added a commit
to jglick/bom
that referenced
this pull request
Sep 18, 2020
…to tests-classifier
dwnusbaum
approved these changes
Sep 18, 2020
raul-arabaolaza
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the problem described in jenkinsci/bom#301 (comment).
I am not proud of this. I suspect this is only one case of a more general problem that PCT fails to update the versions of transitive deps. Ultimately the
pom.xmlmanipulation should be deprecated and replaced with something like jenkinsci/maven-hpi-plugin#66 (just like we already pass-Djenkins.version=…rather than editing the POM when the parent is modern).