-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugins #137
Update plugins #137
Conversation
c042693
to
948e0f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking the experience with https://github.com/jenkinsci/plugin-pom/pull/131/files and JEP-200 regressions in the tests, I suspect that this update is also going to cause it
apache/maven-surefire@f5cca5b needs to be released before we can consider the update |
This reverts commit 2e04121.
@oleg-nenashev I reverted surefire and failsafe updates. |
|
Git-plugin PR is successful jenkinsci/git-plugin#641 FTR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maven Deploy needs to be reverted, preferably with a TODO comment.
The rest LGTM
</plugin> | ||
<plugin> | ||
<artifactId>maven-compiler-plugin</artifactId> | ||
<version>3.6.1</version> | ||
<version>3.8.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally needed for support of higher Java levels. Also updated in #133
This reverts commit eddf94f. Also added a note as to why/until what this upgrade must be postponed.
@oleg-nenashev reverted the m-deploy-p bump with a comment. Care to have another look? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks good
It also fixes https://issues.apache.org/jira/browse/MDEP-571 |
Round of plugins update based on
versions:display-plugins-updates
, similar to jenkinsci/pom#37I left aside:
frontend-maven-plugin
handled in a dedicated PR (Update frontend-maven-plugin from 1.4 to 1.6 #138).access-modifier
because it creates issues with RequireUpperBoundDeps which I'll probably handle separately to keep this PR more straightforward, given there's already enough things touched here.✔️ Successful PR build of this on the
git-plugin
(using3.29-20181202.133920-6
): [DO NOT MERGE] Test round of plugins updates from parent pom git-plugin#641Output was: