Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update localizer plugin #150

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Update localizer plugin #150

merged 2 commits into from
Dec 3, 2020

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Dec 1, 2020

updates the localizer plugin to 1.28 (adds threadsagety support for parallel builds, and messages from XML)
kohsuke/localizer@localizer-parent-1.26...localizer-parent-1.28

oleg-nenashev
oleg-nenashev approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They could have changed the groupId as well, right?

@jtnord
Copy link
Member Author

jtnord commented Dec 1, 2020 •
edited
Loading

They could have changed the groupId as well, right?

they was me... but this project has been setup to allow pushing to maven central (but not actually done IIUC) so I did not want to make that change.

@jglick
Copy link
Member

jglick commented Dec 1, 2020

this project has been setup to allow pushing to maven central (but not actually done IIUC)

Well, some versions, but not recent: https://search.maven.org/artifact/org.jvnet.localizer/maven-localizer-plugin

This is one of those projects we would really prefer to move into @jenkinsci if we could get @kohsuke on board.

@jtnord
Copy link
Member Author

jtnord commented Dec 1, 2020

Well, some versions, but not recent: https://search.maven.org/artifact/org.jvnet.localizer/maven-localizer-plugin

that was IIUC the old java.net publishing. @kohsuke can push now via OSSRH https://issues.sonatype.org/browse/OSSRH-26780 / kohsuke/localizer#7

@jtnord jtnord mentioned this pull request Dec 1, 2020
Merged
10 tasks
@oleg-nenashev
Copy link
Member

Let's get it release anyway. Thanks @jtnord !
+1 for moving to Jenkins or elsewhere

@oleg-nenashev oleg-nenashev merged commit ba58f80 into jenkinsci:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtnord @jglick @oleg-nenashev