Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find myself forgetting to apply spotless before committing.
On some repositories, I have set up a pre-commit git hook running
mvn spotless:check
. However, this has to be set up on each repository that has spotless check enabled, and disabled on those which don't.I think this goes one step further, by defining a conventional maven profile
may-spotless-apply
that will runspotless:apply
only if spotless is enabled for the given repository.This allows any user to incorporate
-Pmay-spotless-apply
as part of their usual build command (or defined in their maven settings active profiles section), and havespotless:apply
automatically called if the project has it enabled.See also jenkinsci/plugin-pom#1017
Testing done
Submitter checklist