Address JENKINS-69757 by adding tests for util class #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice @henriquepaes1 this looks good and looks ready to be merged. |
MarkEWaite
approved these changes
Dec 27, 2024
src/test/java/jenkins/advancedqueue/util/PrioritySorterUtilTest.java
Outdated
Show resolved
Hide resolved
MarkEWaite
added a commit
that referenced
this pull request
Dec 29, 2024
* Bump io.jenkins.tools.bom:bom-2.452.x (#415) * Add test for JobInclusionFolderProperty class and added a constructor in ItemInfo.java" * Address JENKINS-69757 by adding tests for util class (#417) * add tests for util class * Use JUnit 4 assertions with JUnit 4 tests --------- Co-authored-by: Mark Waite <[email protected]> * Modified the setup method to reuse the JobInclusionFolderProperty object * Justify public constructor with a comment * Use JenkinsRule name consistent with other tests * Remove unused ItemInfo and tearDown * Remove unnecessary changes to ItemInfo * Create project once for all tests * Add a few more assertions * Remove queue related assertions --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Henrique Paes <[email protected]> Co-authored-by: Mark Waite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve test coverage for the plugin as described here, this PR adds tests to a class used to fill a ListBoxModel with the specified priorities. The tests asserts that lists are properly created according to the parameters passed.
Submitter checklist