[JENKINS-66938] Allow 2 or more priority definitions to be saved #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tables to divs fixes in release 4.0.0 of the plugin had the side effect of preventing the second or later save of priority definitions that contained more than one priority. In my example, I defined a "High" priority, a "Low" priority, and a "Default" priority. When trying to save that definition, it initially succeeds, then fails later attempts to save it. It is unclear why the assignment of a class to the HTML select element would cause the Stapler response to include unexpected data.
|
@timja I don't understand why these changes resolve the issue (especially the removal of the |
9 tasks
|
I can have a look next week, removing the class is weird |
|
Thanks @timja . I'm going to release a new version of the plugin with this change so that users are unblocked. When we understand the root cause of the issue, we can restore the class and release it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-66938 Save non-trivial priority definitions
Special thanks to @monluk for the April 2021 fix to one of the issues discovered here.
See also: