Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize plugin for June 2023 #244

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Modernize plugin for June 2023 #244

merged 1 commit into from
Jun 22, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jun 22, 2023

  • Remove usages of Guava
  • Replace JSR 305 annotations with SpotBugs annotations
  • Latest parent POM and BOM
  • HtmlUnit migration

Tests pass locally.

Your checklist for this pull request

  • Pull request title represents the changelog entry which will be used in Release Notes. JIRA issue is a part of the title (see existing PRs as examples)
  • Please describe what you did. Short summary for reviewers. If the change involves WebUI, add screenshots
  • Link to relevant Jenkins JIRA issues or pull requests
  • Test automation, if relevant. We expect autotests for all new features or complex bugfixes
  • Documentation if relevant (new features). We want to use Documentation-as-Code, just put docs to README or to new Doc files
  • Javadoc for new APIs. Any public/protected method is considered as API unless annotated by Restricted (docs)

CC

@mention

@basil basil added the internal label Jun 22, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil requested a review from a team June 22, 2023 17:46
@MarkEWaite MarkEWaite merged commit 75ab309 into jenkinsci:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants