-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-26836] Workflow support #28
Conversation
This is required to properly report failure from Workflow.
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
* "repo sync". | ||
*/ | ||
@DataBoundSetter | ||
public void setCurrentBranch(@CheckForNull final boolean currentBranch) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a primitive data type can't be null
, so the annotation is void.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Besides the defaults and the env concern it looks good. |
[JENKINS-26836] Workflow support
Hey, We've been testing out RepoScm under pipeline and it is working pretty well. We are pretty much at par with the functionality we had running repo under an sh step. However we are currently experiencing the following issue when RepoScm tries to generate a changelog: |
Update the plugin according to the workflow compatibility guidelines: https://github.com/jenkinsci/workflow-plugin/blob/master/COMPATIBILITY.md, to support using as part of a workflow.
This fixes https://issues.jenkins-ci.org/browse/JENKINS-26836.