Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26836] Workflow support #28

Merged
merged 4 commits into from
Jan 21, 2016

Conversation

francoisferrand
Copy link

Update the plugin according to the workflow compatibility guidelines: https://github.com/jenkinsci/workflow-plugin/blob/master/COMPATIBILITY.md, to support using as part of a workflow.

This fixes https://issues.jenkins-ci.org/browse/JENKINS-26836.

Francois Ferrand added 2 commits December 22, 2015 11:41
This is required to properly report failure from Workflow.
@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

* "repo sync".
*/
@DataBoundSetter
public void setCurrentBranch(@CheckForNull final boolean currentBranch) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a primitive data type can't be null, so the annotation is void.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@rsandell
Copy link
Member

rsandell commented Jan 5, 2016

Besides the defaults and the env concern it looks good.

rsandell added a commit that referenced this pull request Jan 21, 2016
[JENKINS-26836] Workflow support
@rsandell rsandell merged commit c7c1ff8 into jenkinsci:master Jan 21, 2016
@francoisferrand francoisferrand deleted the workflow-support branch January 25, 2016 10:27
@ghost
Copy link

ghost commented Mar 31, 2016

Hey,

We've been testing out RepoScm under pipeline and it is working pretty well. We are pretty much at par with the functionality we had running repo under an sh step.

However we are currently experiencing the following issue when RepoScm tries to generate a changelog:
https://issues.jenkins-ci.org/browse/JENKINS-33958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants