Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump dependencies #220

Merged
merged 3 commits into from
Dec 5, 2024
Merged

chore(deps): bump dependencies #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de48b28
chore(deps): bump dependencies
Dec 4, 2024
73c4fce
build only on java 17
Dec 4, 2024
f945188
fix: SpotBugs: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Spotbug
Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions .idea/runConfigurations/rest_list_parameter__package_.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
buildPlugin(useContainerAgent: true, configurations: [
[ platform: "linux", jdk: "11" ],
[ platform: "linux", jdk: "17" ]
])
21 changes: 13 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.88</version>
<version>5.3</version>
<relativePath />
</parent>

<properties>
<changelist>999999-SNAPSHOT</changelist>
<!-- Baseline Jenkins version you use to build the plugin. Users must have this version or newer to run. -->
<jenkins.version>2.387.1</jenkins.version>
<bom.artifactId>2.387.x</bom.artifactId>
<bom.version>2143.ve4c3c9ec790a</bom.version>
<java.level>11</java.level>
<jenkins.version>2.479.1</jenkins.version>
<bom.artifactId>2.479.x</bom.artifactId>
<bom.version>3768.veb_7cdc7a_6cc1</bom.version>
<java.level>17</java.level>
<!--
Other properties you may want to use:
~ jenkins-test-harness.version: Jenkins Test Harness version you use to test the plugin. For Jenkins version >= 1.580.1 use JTH 2.0 or higher.
Expand Down Expand Up @@ -45,6 +45,11 @@
<name>h1dden-da3m0n</name>
<url>https://github.com/h1dden-da3m0n</url>
</developer>
<developer>
<id>mymarche</id>
<name>Mikhail Marchenko</name>
<url>https://github.com/mymarche</url>
</developer>
</developers>

<issueManagement>
Expand Down Expand Up @@ -103,12 +108,12 @@
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>okhttp-api</artifactId>
<version>3.14.9</version>
<version>4.11.0-181.v1de5b_83857df</version>
</dependency>
<dependency>
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path</artifactId>
<version>2.8.0</version>
<version>2.9.0</version>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
Expand All @@ -120,7 +125,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>antisamy-markup-formatter</artifactId>
<version>159.v25b_c67cd35fb_</version>
<version>162.v0e6ec0fcfcf6</version>
<optional>true</optional>
</dependency>

Expand Down
6 changes: 5 additions & 1 deletion src/main/java/io/jenkins/plugins/restlistparam/logic/RestValueService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@
try (Response response = client.newCall(request).execute()) {
int statusCode = response.code();
if (statusCode < 400) {
container.setValue(response.body() != null ? response.body().string() : "");
String value = "";
okhttp3.ResponseBody body = response.body();
if (body != null)

Check warning on line 149 in src/main/java/io/jenkins/plugins/restlistparam/logic/RestValueService.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 149 is only partially covered, one branch is missing
value = body.string();
container.setValue(value);
}
else if (statusCode < 500) {
log.warning(Messages.RLP_RestValueService_warn_ReqClientErr(statusCode));
Expand Down
Loading