Fix windows path issue while wildcarding #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We deployed a local build of this on our Jenkins instance and confirmed the changes |
|
Is there anything preventing this from being merged? For what it's worth, looks good to me. Whenever this pull request is merged, https://issues.jenkins-ci.org/browse/JENKINS-16025 should be updated. There're more than a few people running in to this bug. |
|
Exact same issue here. Any plans on merging that pull request and releasing a new version? Thanks in advance, |
|
LGTM 👍 |
|
Thanks for checking @ndeloof |
ndeloof
added a commit
that referenced
this pull request
Oct 7, 2015
Fix windows path issue while wildcarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the S3 plugin configured with the source parameter as
trunk/build/resources/**/*on Windows builders.As windows uses a backslash (
\) instead of normal slashes (/) S3 appended this to the filename. Meaning in the target folder, a file was created with a namemy-really\cool-file.ymlinstead of convertingmy-reallyto a folder.This pull request fixes that bug by converting backslashes to slashes before defining the Destination in S3