Optional GZIP encoding #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndeloof we would appreciate if you will take a look on it since we want this feature ASAP in a mainstream of plugin so we can switch to it instead of a fork :) Thanks! |
|
@bsideup done. |
|
@ndeloof thanks for such a fast reaction :) Contact Simon by using following email: simon at zeroturnaround.com, he will provide you some details on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here, at ZeroTurnaround, we use S3 to serve static websites. Since S3 doesn't support GZIP compression by default, only one option is to set "Content-Encoding: gzip" and gzip files before.
It could be done automatically in plugin as an option, and this pull request implements this logic.
We use fork based on this change and it works fine (but of course additional testing on accepting would be good).
Also, this change will improve old behaviour as well because it will always use an InputStream of a file, and if file is a remote file then it will use a stream without putting it to the temporary file (we still need this temp file for gzipping because we don't want to get some OutOfMemory errors )
Thanks!