Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jenkins infra maven cd reusable workflow #235

Merged

Conversation

jetersen
Copy link
Member

🤖 Beep boop!

This is an automatic pull request that updates your GitHub action used for continous delivery workflow for this repository.

Switching to using a reusable workflow created to simplify maintance of this file in your repository.

In case of questions, please ping @jetersen.

Additional informations:
You can find the workflow here
Full explaination

@kuisathaverat kuisathaverat merged commit 15c036d into jenkinsci:main Jul 19, 2022
@kuisathaverat
Copy link

kuisathaverat commented Jul 19, 2022

@jetersen this PR has a couple of typos, there are two ´ extra characters in the environment variables

      MAVEN_USERNAME: `${{ secrets.MAVEN_USERNAME }}
      MAVEN_TOKEN: `${{ secrets.MAVEN_TOKEN }}

@jetersen
Copy link
Member Author

Oh I am terrible sorry! I did not even notice.

@jetersen
Copy link
Member Author

I have fixed in any open PRs.

Only a few PRs were closed with the typo in it.

@kuisathaverat
Copy link

kuisathaverat commented Jul 19, 2022

I have fixed in any open PRs.

Only a few PRs were closed with the typo in it.

I guess I was too fast to merge it 😄, thanks for maintain this, it is really nice to release directly from GitHub

@jetersen
Copy link
Member Author

All credit goes to @jglick for releasing directly from GitHub 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants