Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist jenkins.model.Jenkins.VERSION #548

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Dec 18, 2023

useful when you need the Jenkins version in a pipeline (e.g. to obtain a corresponing agent image for k8s plugin)

Testing done

Submitter checklist

Preview Give feedback

useful when you need the Jenkins version in a pipeline (e.g. to obtain a corresponing agent image for k8s plugin)
@jtnord jtnord changed the title whitelist jenkins.model.Jenkin.VERSION whitelist jenkins.model.Jenkins.VERSION Dec 18, 2023
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harmless to whitelist. Something like jenkinsci/workflow-basic-steps-plugin#71 would be better if it existed I think.

@jglick jglick changed the title whitelist jenkins.model.Jenkins.VERSION Whitelist jenkins.model.Jenkins.VERSION Dec 18, 2023
@jtnord jtnord marked this pull request as ready for review December 19, 2023 10:31
@jtnord jtnord requested a review from a team as a code owner December 19, 2023 10:31
@jtnord
Copy link
Member Author

jtnord commented May 30, 2024

ping @car-roll @rsandell

@rsandell rsandell merged commit a2819b4 into jenkinsci:master May 30, 2024
14 checks passed
@jtnord jtnord deleted the patch-1 branch May 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants