[FIXED JENKINS-40362] Upgrade sshd-core to 0.14.0 to pick SSHD-330 #8
Conversation
This solves a really bad issue where 1 handshake in 256 fails randomly [1]. Note: The issue was easily reproducable, and after this dependency upgrade the handshake did not fail in over 15K test connections. [1] https://issues.apache.org/jira/browse/SSHD-330
|
I would also use the opportunity and enable the new Ciphers (see the discussion in jenkinsci/jenkins#2641). But I can do it in the follow-up PR |
|
@GLundh Just in case, is there an issue in the Jenkins CI bugtracker for it? If no, I'll create the new one since it may be useful to backport it to 2.32.x |
|
CC @jenkinsci/code-reviewers |
|
@oleg-nenashev: I have not found an Jenkins-issue on this. Please notice that there are later versions of sshd-core, but I went with 0.14.0 since it is well tested in other high traffic services we run (like Gerrit v2.12). It was also straightforward enough to upgrade too, without too much changes in the logic on the Jenkins side. Just the signature on the AbstractKeyPairProvider.loadKeys(), so it felt like a good match. |
|
Is there any chances of having it backported to older LTS's? I am mainly thinking about 1.651.x. Not everyone is yet ready for the 2.x jump :) |
|
Ah.. I see now you have already had the 0.14.0 vs 1.x discussion. Great 👍 |
Well, we do not ship new releases of this LTS branch. On the other hand, you can build your own custom core with a patch (you a common multi-module Maven project). The code of this LTS branch is available here: https://github.com/jenkinsci/jenkins/tree/stable-1.651. With local builds you will have no JAR/WAR signing, but it is not a common requirement for deploying Jenkins to web containers. |
oleg-nenashev
changed the title
|
Merging this change in order to get it in the Weekly. Jenkins-internal issue: https://issues.jenkins-ci.org/browse/JENKINS-40362, will mark it as LTS candidate |
oleg-nenashev
changed the title
This solves a really bad issue where 1 handshake
in 256 fails randomly [1].
Note: The issue was easily reproducable, and after this
dependency upgrade the handshake did not fail in over
15K test connections.
[1] https://issues.apache.org/jira/browse/SSHD-330