-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incrementalify plugin #6
Conversation
target | ||
|
||
# mvn hpi:run | ||
work | ||
|
||
# IntelliJ IDEA project files | ||
*.iml | ||
*.ipr | ||
*.iws | ||
target | ||
*.ipr | ||
.idea | ||
|
||
# Eclipse project files | ||
.settings | ||
.classpath | ||
.project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent with the archetype.
<distributionManagement> | ||
<repository> | ||
<id>repo.jenkins-ci.org</id> | ||
<url>https://repo.jenkins-ci.org/public/</url> | ||
</repository> | ||
</distributionManagement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed, as this is provided by the parent POM.
<maven.version>2.0.1</maven.version> | ||
<spotbugs.skip>true</spotbugs.skip> | ||
<spotbugs.threshold>High</spotbugs.threshold> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were only a few high-priority SpotBugs warnings, so I suppressed them and turned this on so that we at least discover new high-priority SpotBugs warnings.
@@ -52,9 +47,11 @@ | |||
</pluginRepositories> | |||
|
|||
<properties> | |||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed, as this is provided by the parent POM.
Incrementalifying the plugin activates the Javadoc generation, which exposes some other problems. I'll try to fix that up. |
I extracted the incremental part from #5 in order to prevent possible conficlits with the upcoming configuration. |
Fixed the Javadoc generation by migrating to some more modern Maven annotations. |
Making this plugin consistent with other core components that produce incremental builds that can be used for testing.