Verifying that web methods may be defined as default interface methods #113
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
CI build is getting a SIGKILL for some reason. |
|
In fact this build passed so it is just odd that there seem to be two jobs building the same repo. I will disable the other! |
| @@ -83,7 +83,7 @@ | |||
|
|
|||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <java.level>7</java.level> | |||
| <java.level>8</java.level> | |||
There was a problem hiding this comment.
Requires a decision by Stapler maintainers. LGTM, but may require extra backporting methods if somebody wants to just update LTS version to the Master branch. I don't
There was a problem hiding this comment.
Requires a decision by Stapler maintainers.
Well, I cut the last release…
if somebody wants to just update LTS version to the Master branch
I think generally we do not do that. Rather, we would create a backport branch and cherry-pick selected fixes.
|
@reviewbybees done |
|
but CC @kohsuke in case he has any opinion |
|
Will hold off on merge just in case. |
Relevant since Jenkins core is now on
-source 8.@reviewbybees