Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs references to html files (use .adoc) #337

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

francoisfreitag
Copy link
Contributor

When browsing the documentation on GitHub, the links are broken as they
refer to an HTML document, which has been changed to adoc in commit
ff4f5b4.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

When browsing the documentation on GitHub, the links are broken as they
refer to an HTML document, which has been changed to adoc in commit
ff4f5b4.
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the broken link. I've confirmed that link is broken on the master branch and that this change fixes it.

@basil basil enabled auto-merge (squash) March 7, 2022 16:19
@francoisfreitag
Copy link
Contributor Author

The parameter injection link at https://github.com/jenkinsci/stapler/blob/master/docs/reference.adoc#action-method is broken, but I didn’t see a replacement.

@basil basil merged commit 6073351 into jenkinsci:master Mar 7, 2022
@basil
Copy link
Member

basil commented Mar 7, 2022

The parameter injection link at https://github.com/jenkinsci/stapler/blob/master/docs/reference.adoc#action-method is broken, but I didn’t see a replacement.

According to this page, this content once lived at http://stapler.java.net/parameter-injection.html, but that page is not even present on archive.org. Unless @kohsuke has a backup, I think this content is lost to the mists of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants