Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for StaplerClosureScript._ #344

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 21, 2022

@@ -37,6 +39,30 @@ public void testFoo() throws IOException, JellyTagException {
Files.delete(tmp);
}
}

public void testGettext() throws Exception {
Path tmp = Files.createTempFile("xxx", ".groovy");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice at some point to convert to JUnit 4 and use TemporaryFolder.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@basil basil enabled auto-merge (squash) March 21, 2022 18:53
@basil basil merged commit 97ab5d8 into jenkinsci:master Mar 21, 2022
@jglick jglick deleted the gettext branch March 21, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants