Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some exception handling that was forgotten as part of JEP-227 #413

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Some exception handling that was forgotten as part of JEP-227 #413

merged 2 commits into from
Oct 27, 2022

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 26, 2022 •
edited
Loading

Existing logic introduced in 1a07292

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe requested a review from jglick October 26, 2022 16:03
@jglick jglick added the bug label Oct 26, 2022
@jglick jglick requested a review from a team October 26, 2022 16:14
jglick
jglick approved these changes Oct 26, 2022
View reviewed changes
core/src/main/java/org/kohsuke/stapler/Stapler.java Outdated Show resolved Hide resolved
core/src/main/java/org/kohsuke/stapler/Stapler.java Outdated Show resolved Hide resolved
core/src/main/java/org/kohsuke/stapler/Stapler.java Outdated Show resolved Hide resolved
basil
basil approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Vlatombe Vlatombe enabled auto-merge October 27, 2022 07:44
@Vlatombe Vlatombe merged commit 9580b2f into jenkinsci:master Oct 27, 2022
@Vlatombe Vlatombe deleted the missing-exception-handling-JEP-227 branch February 22, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@basil basil basil approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vlatombe @basil @jglick