Log warning when doing bytecode analysis #529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
BytecodeReadingParanamer
is not sustainable in the long term, so introduce a warning to more aggressively call out plugins that are still being built with an ancient HPI/JPI toolchain. I tried this out on the plugins in BOM and none of them showed a warning. Print the warning only a single time per signature to avoid spamming log files.The only plugin I am aware of that will trigger this warning in production is the Gradle plugin.
Testing done
Compiled Text Finder with
mvn clean verify -Dmaven.compiler.parameters=false
and saw these warning as expected:Ensured that these warnings appeared only once even after refreshing the pages that produced them.