Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37664] Immediately throw an EOF in a boundary error condition #78

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 24, 2016

JENKINS-37664

@reviewbybees

@ghost
Copy link

ghost commented Aug 24, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev
Copy link
Member

🐝
We may likely need a stable stapler 1.243.x branch since the master 1.244 release is borked.
This fix likely deserves backporting, but I'm not sure 1.244 features are safe enough.

@svanoort
Copy link
Member

I 🐝 lieve this looks reasonable

@jglick
Copy link
Member Author

jglick commented Aug 25, 2016

This fix likely deserves backporting

Not sure. I believe I am now working around it in the reported case in jenkinsci/workflow-job-plugin#18. Of course there could be other cases where this method is called with an illegally large argument, but if these are not being reported as a problem by users then we do not need to backport it aggressively.

@jglick jglick merged commit 311dcfd into jenkinsci:master Aug 25, 2016
@jglick jglick deleted the hang-JENKINS-37664 branch August 25, 2016 14:20
@daniel-beck daniel-beck mentioned this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants