Remove unused logging.properties that is shipped on the classpath #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was currently looking at exactly the same and also confused as this file was not packaged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #99, I realized there was another
logging.propertieschecked in atclient/src/main/java/hudson/plugins/swarm/logging.properties. This was completely unused. I thought it was confusing that we ship dead code on the classpath, so I simply deleted this. The one I checked in atclient/logging.propertieswas almost the same. I fixed it up to include a few other goodies from the originalclient/src/main/java/hudson/plugins/swarm/logging.properties(e.g.,%uin the filename, andjava.util.logging.SimpleFormatter.format). Otherwise, the only other differences were increased verbosity, which is actually a good thing given that users should be only using it when they are in a debugging situation. With these differences having been reconciled, I am deleting the oldclient/src/main/java/hudson/plugins/swarm/logging.properties. It should now be clear that the JAR ships with no logging configuration, and if users want to turn up logging they will need to copy the file fromclient/logging.propertiesto the filesystem (not classpath!) and enable it as described in the documentation.