Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent POMs #203

Merged
merged 2 commits into from
May 4, 2020
Merged

Update parent POMs #203

merged 2 commits into from
May 4, 2020

Conversation

basil
Copy link
Member

@basil basil commented May 4, 2020

Updates jenkinsci/pom from 1.54 to 1.55 and jenkinsci/plugin-pom from 3.56 to 4.1.

Version 1.55 of pom added findsecbugs, which is a great idea but turns up some warnings in the current codebase which I don't have time to go through right now. I excluded these to maintain the status quo. These can be examined in the future one by one.

Version 4.x of plugin-pom requires Jenkins 2.164.x or later, so updated jenkins.version to 2.164.3.

As a bonus, I fixed a deprecation warning in TestUtils by switching from org.junit.Assert.assertThat to org.hamcrest.MatcherAssert.assertThat.

@basil basil closed this May 4, 2020
@basil basil reopened this May 4, 2020
@basil basil merged commit bf722bd into jenkinsci:master May 4, 2020
@basil basil added the internal Internal changes label May 4, 2020
@basil basil deleted the pom branch May 4, 2020 19:44
@basil basil added dependencies Pull requests that update a dependency file and removed internal Internal changes labels May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant