Command-line option for specifying Node.Mode (and handling for it on the plugin side) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a command-line option to the Client to specify the mode to be sent to the master node (either 'normal' or 'exclusive' which correspond to values in hudson.model.Node.Mode) - Added a specific OptionHandler to parse those - Added another @QueryParameter to hudson.plugins.swarm.PluginImpl to make sure the mode gets correctly applied - Added Mode as a parameter to the SwarmSlave constructor that's being called from PluginImpl
|
Jenkins » swarm-plugin #7 SUCCESS |
|
I guess the biggest reason I would like this feature is that one should be able to make the ad-hoc Swarm slaves "exclusive" so that they do not accidentally interfere with other jobs (which you might not want). |
ssogabe
added a commit
that referenced
this pull request
May 16, 2013
Command-line option for specifying Node.Mode (and handling for it on the plugin side)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sent to the master node (either 'normal' or 'exclusive' which
correspond to values in hudson.model.Node.Mode)
make sure the mode gets correctly applied
called from PluginImpl