Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.adoc: add common rationales for Swarm in the intro #318

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

jimklimov
Copy link
Contributor

@jimklimov jimklimov commented Apr 27, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Updated the README which used to say no arguments are required: in version 3.25 the JAR refuses to start without a -master URL CLI option. Technically options to log in may be not required, if the anonymous user is given Agent/* permissions in the Matrix strategy (checked to be so) - but this is not something we would encourage, right?

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
jimklimov and others added 3 commits April 27, 2021 19:30
Co-authored-by: Basil Crow <[email protected]>
Co-authored-by: Basil Crow <[email protected]>
Co-authored-by: Basil Crow <[email protected]>
@jimklimov
Copy link
Contributor Author

jimklimov commented Apr 27, 2021

@basil: Thanks for the good catches and other improvements. And for a quick reaction to PRs :)

@basil basil merged commit 3c65473 into jenkinsci:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants