Fix fsroot option name when used in YAML config file #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this was the only option which had an internal variable name which differed from the exposed option name. This could be confusing for users wanting to use the new YAML config file format, since it meant that they would need to specify `remoteFsRoot` there, and look at the source code to figure out this option name.
|
Thanks for the PR! Seems reasonable to me. Perhaps @offa has some thoughts as well. |
|
Sorry, I was keeping this PR as a draft until the CI run succeeded. |
basil
approved these changes
Jun 2, 2021
|
@basil Thanks for the quick merge! |
|
Released in 3.27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was the only option which had an internal variable
name which differed from the exposed option name. This could be
confusing for users wanting to use the new YAML config file format,
since it meant that they would need to specify
remoteFsRootthere,and look at the source code to figure out this option name.
Link to relevant issues in GitHub or JiraLink to relevant pull requests, esp. upstream and downstream changes