Add option for -pidFile #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the swarm client as a daemon or with a tools like systemd, it is useful to have a file with the process ID. This commit introduces a new option in the client which will generate that file when the client starts up. The file will be deleted when the process exits.
|
Hi!
I will check this on Monday when I'm back at the office. 🍾
…On Fri, 1 Sep 2017, 10:12 Nik Reiman ***@***.***> wrote:
When running the swarm client as a daemon or with a tools like systemd, it
is useful to have a file with the process ID. This commit introduces a new
option in the client which will generate that file
when the client starts up. The file will be deleted when the process exits.
------------------------------
You can view, comment on, or merge this pull request online at:
#55
Commit Summary
- Fix whitespace
- Add option for -pidFile
File Changes
- *M* client/src/main/java/hudson/plugins/swarm/Client.java
<https://github.com/jenkinsci/swarm-plugin/pull/55/files#diff-0> (21)
- *M* client/src/main/java/hudson/plugins/swarm/Options.java
<https://github.com/jenkinsci/swarm-plugin/pull/55/files#diff-1> (14)
Patch Links:
- https://github.com/jenkinsci/swarm-plugin/pull/55.patch
- https://github.com/jenkinsci/swarm-plugin/pull/55.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#55>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfn_9dmbLrGaZa122GT-VVXgt4JD4umks5sd7xcgaJpZM4PJ1lv>
.
|
|
@mindjiver thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the swarm client as a daemon or with a tools like systemd, it is useful to have a file with the process ID. This commit introduces a new option in the client which will generate that file
when the client starts up. The file will be deleted when the process exits.