-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong offset in large logs when some are skipped. #190
Conversation
Timestamps in large logs written to console have wrong positive offset when logs are partly skipped. So you never see the last timestamp in the situation. Changes made in commit 5a5e7b9 touch Parse From Finish logic and began the offset. They were partly reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you been running this in production, and has it fixed your problem without causing any regressions?
Hi, basil. |
Hi @thesvistun, please install the incremental build from this PR https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/timestamper/1.19-rc755.45f101ddd78a/ on your production server and run it for a week or so. Instructions on how to do so are here: https://www.jenkins.io/doc/book/managing/plugins/#advanced-installation Once this change has been verified on a production instance without regressions I will perform a release. |
Deal. |
Hi, @basil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Released in 1.19. |
Thank you too! |
Timestamps in large logs written to console have wrong
positive offset when logs are partly skipped. So you never
see the last timestamp in the situation.
Changes made in commit 5a5e7b9 touch Parse From Finish logic
and began the offset.
They were partly reverted.