Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dynamic check for Jenkins version in usersettings.jelly #192

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Remove dynamic check for Jenkins version in usersettings.jelly #192

merged 1 commit into from
Sep 8, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 7, 2022

The tricky code introduced in #76 seems to be obsolete as of #151. Also if we ever set up CD for core, it would fail

WARNING	h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: (majorVersion ge 2 and minorVersion ge 238) or majorVersion > 2 in /extensionList/hudson.console.ConsoleAnnotatorFactory/hudson.plugins.timestamper.annotator.TimestampAnnotatorFactory3/usersettings. Reason: java.lang.NumberFormatException: For input string: "999999-SNAPSHOT"
java.lang.NumberFormatException: For input string: "999999-SNAPSHOT"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.base/java.lang.Long.parseLong(Long.java:692)
	at java.base/java.lang.Long.valueOf(Long.java:1144)
	at org.apache.commons.jexl.util.Coercion.coerceLong(Coercion.java:86)
	at …

@jglick jglick requested a review from a team as a code owner September 7, 2022 22:57
basil
basil approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil added the internal label Sep 8, 2022
@basil basil merged commit f94ee2f into jenkinsci:master Sep 8, 2022
@jglick jglick changed the title Remove dynamic check for Jenkins versionin usersettings.jelly Remove dynamic check for Jenkins version in usersettings.jelly Sep 8, 2022
@jglick jglick deleted the sidebar-design-cleanup branch September 8, 2022 00:42
@basil
Copy link
Member

basil commented Sep 8, 2022

https://github.com/jenkinsci/timestamper-plugin/releases/tag/timestamper-1.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @basil