[JENKINS-72690] Make the widget sticky #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the widget sticky so that it stays visible when scrolling down in a long log
mawinter69
changed the title
|
@jenkinsci/timestamper-plugin-developers |
|
Why is this fixing two unrelated issues in a single PR? |
mawinter69
changed the title
split in 2 separate PRs, ideally both go in the same release |
basil
changed the title
|
Released in 1.27. |
6 tasks
|
The TimeStamper panel being sticky causes other panels to be overflown when scrolling, that results in a conflict as was noticed with the Collapsible Section plugin at jenkinsci/collapsing-console-sections-plugin#35 (comment) : If I rollback to 1.26, the Timestamper plugin is scrolled top outside of the viewport. It seems the stickiness should be removed for now until a better solution is found. I have proposed a revert with #311. |
hashar
added a commit
to hashar/timestamper-plugin
that referenced
this pull request
Oct 29, 2024
When other panels have been added to the side bar, they are shown overlapping with the stick timestamper panel which has a transparent background. That is noticeable with the Collapsible Section plugin which can generate a fairly long panel. I understand the use case for making it sticky, but the overlapping text is concerning. This reverts commit b2e06b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the widget sticky so that it stays visible when scrolling down in a long log
After:
Testing done
Manual testing
Submitter checklist