Fixes [JENKINS-64335] #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
balleman-tt
commented
Nov 30, 2020
balleman-tt
commented
- Do not set slaveIsDisconnecting for temporarily offline nodes
* Do not set slaveIsDisconnecting for temporarily offline nodes
|
Thank you for tracking this down & raising this PR 👍 That code has way too much complexity in it for my liking (the joys of old old code!) and, yes, I agree that it looks like commit 7ea9d7a did change the order; you did a good bit of detective work there 😉 Code changes here look good ... mind you, the code changes in #117 looked perfectly reasonable too so 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.