Java 11 compatibility and refresh dependencies #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjdarton
requested changes
Dec 21, 2020
There was a problem hiding this comment.
While an overhaul (by someone who clearly understands Jenkins dependencies etc more than I do) is most welcome, making the minimum Jenkins version more recent than a year old is less so.
So.... how far back in the past can we push the minimum without losing too many of the benefits?
|
Can you provide a description please? What's the intent behind these changes? Why is this necessary etc? |
|
The background is for this: #126 |
pjdarton
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bom so that dependencies are tested against each other, known to be compatible and guaranteed not to cause dependency conflicts with enforcer
exclusion added on Lombok because of impropery packaged dependency that breaks compilation on java 11
updated to a recent core to support building with java 11, bom, Jenkins core bom, to test against a more supported version of Jenkins that’s more realistic to what users use, version chosen by following https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/