Disconnect vsphere #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After launching a VM or finishing a build step, disconnect from the vSphere server so that the number of active/idle connections does not keep growing.
In the earlier state, the plugin connected to vSphere without checking if the slaveComputer was online and then looked at the power state of the VM. If offline, it simply came out and forgot to disconnect (leaving a session behind). Wrapping the connection inside an if construct (checking if the slave computer is online). Note that there might be a difference between a slave computer state being anything but online and the VM still powered on. This is a temporary solution to avoid huge number of requests getting to the vSphere server.
If the disconnect method is not called, there will be 1 idle session left on the vSphere server.
This check is causing the VM to stay powered on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our vCenter admins observed that there were simply too many open / idle sessions on vCenter using the login provided to Jenkins vSphere cloud plugin. This set of changes attempts to disconnect from the vCenter after whatever work was needed to be done.