Logging improvments. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vSphereCloud's Log methods now log exceptions with Level.SEVERE instead of Level.INFO. Non-exception logging is still Level.INFO. vSphereCloudProvisionedSlave and vSphereCloudSlave's _terminate methods had some code paths that could fail silently - they now log something.
elordahl
reviewed
Jun 28, 2017
| final vSphereCloudLauncher launcher = (vSphereCloudLauncher) getLauncher(); | ||
| if (launcher != null) { | ||
| final vSphereCloud cloud = launcher.findOurVsInstance(); | ||
| if (cloud != null) { |
There was a problem hiding this comment.
Is there a reason this cloud != null check was removed? Is an NPE possible here?
There was a problem hiding this comment.
findOurVsInstance() will throw an exception - it won't return null.
There was a problem hiding this comment.
I managed to miss off the extra Javadoc I'd added to make this clear from my PR.
I've added another commit that adds this.
(my local code had this javadoc already, but I'm in the process of un-picking my changes into a series of discrete PRs, and this comment got missed out. Sorry for the confusion)
elordahl
approved these changes
Jun 28, 2017
Make it obvious that this method does not return null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vSphereCloud's Log methods now log exceptions with Level.SEVERE instead of Level.INFO. Non-exception logging is still Level.INFO.
vSphereCloudProvisionedSlave and vSphereCloudSlave's _terminate methods had some code paths that could fail silently - they now log something.