Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-45786] Add readResolve() to VSphereCloudRetentionStrategy #82

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

balleman
Copy link

to ensure super.idleMinutes is properly restored from persistent state

to ensure super.idleMinutes is properly restored from persistent state
@pjdarton
Copy link
Member

Thanks for doing this - it's much appreciated.
My personal workload has been such that I've not been able to look at & test the build that was produced from this PR yet, but I hope to finish that interruption off tomorrow and then I'll be able to test the resulting plugin and merge it if it all works as expected.
If you hear nothing by the end of this week, feel free to nag me :-)

@pjdarton
Copy link
Member

pjdarton commented Aug 2, 2017

OK, this looks good to me - it fixes the problem I was trying to solve with #78 but with far less code changes. I'll close #78 and merge this one.

@pjdarton pjdarton mentioned this pull request Aug 2, 2017
@pjdarton pjdarton merged commit bbdd062 into jenkinsci:master Aug 2, 2017
@balleman balleman deleted the vscrs_readresolve branch January 7, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants