[JENKINS-56418] Add custom rflint icon #18
Conversation
Change Description: When RfLint parser is used, the Jenkins build URL does not display a Robot Framework logo on the Jenkins Build URL page, instead, an "Attention" icon is displayed. This change ensure the Robot Framework logo is used when the respective parser Testing Done: 1. Spun up a local Jenkins instance 2. Installed the warning-ng plugin by uploading the HPI file via the Jenkins UI 3. Create a freestyle project that uses the flint parser 4. Triggered a build and ensured the UI is displaying the logo correctly
|
Is it intentional that you have a lot of empty pixels as border around the image? Therefore the image looks smaller than the rest... |
|
The Travis-ci build failed with
Any guidance on how to fix them is appreciated. |
|
Regarding the image, I just took the official image from ework/visual-identity/blob/master/README.rst#id3 and resized it |
|
Ok, this is your decision on how the icon looks. I thought it would make more sense without empty pixels around the png. Can you please also add a short note about the icon license in the Lincense.txt file in the same folder? Don't worry about the build failure, this happens sometimes... |
|
I'll following up with the Robot framework community regarding the empty pixels around the PNG. I agree it would be better to remove them. |
src/main/webapp/icons/LICENSE.txt
Outdated
|
|
||
| License for RootFramework Icons | ||
|
|
||
| https://github.com/robotframework/visual-identity |
There was a problem hiding this comment.
I think it should be Creative Commons Attribution-ShareAlike 4.0 International License
There was a problem hiding this comment.
Yes, it seems to be the case
There was a problem hiding this comment.
My preference is to point to the github repository in the event the robotframework project decides to change the license.
There was a problem hiding this comment.
Well actually that is why I want to have the actual license here. Otherwise we may have a conflict if they change the web site later on. This seems pedantic but image licensing is a big deal in the internet.
As a compromise: add both lines, URL and license?
There was a problem hiding this comment.
Makes sense. I updated the license.txt to indicate this.
|
As far as I understood https://github.com/robotframework/visual-identity the space around the logo is intentional. |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
+ Coverage 80.85% 80.85% +<.01%
Complexity 1412 1412
============================================
Files 224 224
Lines 4742 4743 +1
Branches 384 384
============================================
+ Hits 3834 3835 +1
Misses 774 774
Partials 134 134
Continue to review full report at Codecov.
|
|
Thanks! |
Change Description
When RfLint parser is used, the Jenkins build URL does not display a Robot Framework logo on the Jenkins Build URL page, instead, an "Attention" icon is displayed. This change ensure the Robot Framework logo is used when the respective parser
Testing Done
This fixes JENKINS-56418
Before
After