-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/phpstan #21
Feature/phpstan #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
===========================================
- Coverage 80.84% 80.8% -0.05%
- Complexity 1371 1373 +2
===========================================
Files 225 226 +1
Lines 4684 4695 +11
Branches 375 375
===========================================
+ Hits 3787 3794 +7
- Misses 743 747 +4
Partials 154 154
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the icon also available under an OSS or community license? It can be integrated as well if you like...
public class PhpStan extends ReportScanningTool { | ||
private static final long serialVersionUID = 2699509705079011738L; | ||
|
||
static final String ID = "phpstan"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I changed that in all other parsers as well:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the visibility to private.
I've also rebased on master to resolve the merge conflict in the SUPPORTED-FORMATS.md file
bb0b2f9
to
6d2985a
Compare
Regarding the image I haven't been able to find information on the license of the icon. |
Alright, I was able to check it with the developers and I was told that we can use the logo for this purpose. |
Nice, thanks! Can you please add a line or reference to the icon license (or to the discussion) in the LICENSE.txt file in the icons folder? |
And one more thing, can you add a small test case to ParsersITest that shows that your parser correctly finds n warnings. No need to check for individual properties, since this is done in the check style parser test. |
Thank you very much! |
This PR adds support for PHPStan using the CheckStyleParser.