-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IBLinter (Swift storyboard linter) #27
Conversation
why Jenkins build is not done after 8h? |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
===========================================
- Coverage 79.78% 79.7% -0.09%
Complexity 1401 1401
===========================================
Files 232 233 +1
Lines 4977 4986 +9
Branches 394 394
===========================================
+ Hits 3971 3974 +3
- Misses 847 853 +6
Partials 159 159
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please create a small test in ParsersITest? And please add a ChangeLog entry.
I'm afraid not. I do not have any knowledge about Java and IBLinter module which I want to integrate with this plugin. I just copied and updated files from other module which uses the same Checkstyle reporter (SwiftLint) and this module is also not covered by tests so I do not have base example how to rewrite this for IBLinter. I can provide updated changelog. |
Ok, never mind, I can add it later on, the test is just one simple line: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/src/test/java/io/jenkins/plugins/analysis/warnings/ParsersITest.java#L70 Can you provide a small report xml with one warning from your tool? Then I can use it for the test. |
here is XML file generated by IBLinter |
thank you |
Well, thank you! |
@uhafner do you have any date when you plan to release this PR? |
Followup to jenkinsci#27.
No description provided.