Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IBLinter (Swift storyboard linter) #27

Merged
merged 4 commits into from
Apr 3, 2019
Merged

Add support for IBLinter (Swift storyboard linter) #27

merged 4 commits into from
Apr 3, 2019

Conversation

nysander
Copy link
Contributor

@nysander nysander commented Apr 2, 2019

No description provided.

@nysander
Copy link
Contributor Author

nysander commented Apr 3, 2019

why Jenkins build is not done after 8h?

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #27 into master will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #27      +/-   ##
===========================================
- Coverage     79.78%   79.7%   -0.09%     
  Complexity     1401    1401              
===========================================
  Files           232     233       +1     
  Lines          4977    4986       +9     
  Branches        394     394              
===========================================
+ Hits           3971    3974       +3     
- Misses          847     853       +6     
  Partials        159     159
Impacted Files Coverage Δ Complexity Δ
...io/jenkins/plugins/analysis/warnings/IBLinter.java 33.33% <33.33%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d2432...d04ba1a. Read the comment docs.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a small test in ParsersITest? And please add a ChangeLog entry.

@nysander
Copy link
Contributor Author

nysander commented Apr 3, 2019

I'm afraid not. I do not have any knowledge about Java and IBLinter module which I want to integrate with this plugin. I just copied and updated files from other module which uses the same Checkstyle reporter (SwiftLint) and this module is also not covered by tests so I do not have base example how to rewrite this for IBLinter. I can provide updated changelog.

@uhafner
Copy link
Member

uhafner commented Apr 3, 2019

Ok, never mind, I can add it later on, the test is just one simple line: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/src/test/java/io/jenkins/plugins/analysis/warnings/ParsersITest.java#L70

Can you provide a small report xml with one warning from your tool? Then I can use it for the test.

@nysander
Copy link
Contributor Author

nysander commented Apr 3, 2019

here is XML file generated by IBLinter
updated: test.xml.zip

@uhafner uhafner merged commit 62d321e into jenkinsci:master Apr 3, 2019
@nysander
Copy link
Contributor Author

nysander commented Apr 3, 2019

thank you

uhafner added a commit that referenced this pull request Apr 3, 2019
@uhafner
Copy link
Member

uhafner commented Apr 3, 2019

Well, thank you!

@nysander
Copy link
Contributor Author

nysander commented Apr 7, 2019

@uhafner do you have any date when you plan to release this PR?

micansid pushed a commit to micansid/warnings-ng-plugin that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants