Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double filtering #105

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Prevent double filtering #105

merged 1 commit into from
Dec 3, 2019

Conversation

res0nance
Copy link

Each call to filterator impl iterates the entire collection. calling fetchEnclosingBlocks iterates once and then calling filter with a predicate iterates again. Move to using a filteratorimpl by itself with notAHead as the predicate

@res0nance res0nance closed this Oct 21, 2019
@res0nance res0nance reopened this Oct 21, 2019
dwnusbaum
dwnusbaum approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dwnusbaum dwnusbaum merged commit 61c5608 into jenkinsci:master Dec 3, 2019
@res0nance res0nance deleted the prevent-double-filter branch January 3, 2020 09:39
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@res0nance @dwnusbaum