Start using bom #121
Start using bom #121
Conversation
|
@jglick should I try to flatten the dependencies? remove all the unnecessary ones? |
This. Sometimes a |
removing unnecessary reps Co-Authored-By: Jesse Glick <[email protected]>
|
sorry @jglick, I got confused. |
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-durable-task-step</artifactId> |
There was a problem hiding this comment.
This is definitely being used in tests and so ought to remain as an explicit dependency, even if it happens to also be pulled in from something else.
There was a problem hiding this comment.
Is a test dependency, I guess as far as tests are passing, is all good.
There was a problem hiding this comment.
Looks like it is being pulled in via workflow-basic-steps. Just poor style generally to rely on transitive dependencies for things actually used directly. Anyway yes, if a future update of workflow-basic-steps drops that dep (as is quite possible in this case), updating to that would (I hope!) cause tests to start failing until you readded the explicit workflow-durable-task-step dep.
There was a problem hiding this comment.
I'd say workflow-basic-steps is directly used and its dependencies. But, let me know if you want this added back.
There was a problem hiding this comment.
The node step is used in a few tests. Not important, just FYI.
start using bom dependencies